Repository navigation
feat: add Pod-scoped S3 gateway commands - #19
Merged
Merged
Conversation
dmeijboom
force-pushed
the
feat/s3-gateway
branch
from
November 3, 2026 19:20
fb4086d to
b5946b9
Compare
dmeijboom
marked this pull request as draft
November 3, 2026 20:36
dmeijboom
force-pushed
the
feat/s3-gateway
branch
from
November 3, 2026 20:43
0f7bfbe to
808eba0
Compare
dmeijboom
marked this pull request as ready for review
November 3, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Pod-scoped
s3 ls/cp/mv/upload/download/rmcommands using Brainpod API keys. The AWS SDK handles listing, writes, and multipart operations through a generic Bearer-authenticated gateway adapter. Redirect downloads use separate unauthenticated HTTPS requests; provider requests never receive Bearer credentials.Includes bounded copies, guarded multipart stdin transfers, generic metadata, endpoint configuration, command descriptions, and documentation. Unrelated tunnel and CI work is excluded.
Verified: 127 local tests; offline locked compilation; formatting; CLI smoke checks; and 23 live checks against a local S3 gateway. Live coverage includes all six commands, Unicode/punctuation keys, a 26 MiB multipart roundtrip with matching SHA256 hashes, failure without a producer-success marker, and exact-key cleanup. Test objects were removed and temporary credentials revoked.
Draft / merge blocker: the offline prototype lockfile pins yanked transitive dependency
spin 0.10.0throughcrc-fast. Resolve/review that dependency and rerun checks before marking ready. Cross-platform execution remains unverified locally.XML parsing now delegates entirely to the SDK; the redundant validator and direct XML-parser dependency are removed. Size limits and credential/producer safeguards remain. The live checks above preceded this simplification; the current revision passes 127 local tests and static checks, but live tests were not rerun.